fix(core): make deprecated shorthand fields take precedence when new value is null #13589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/db
schema-change-noteworthy
cherry-pick kong-ee
nowNick
force-pushed
the
fix/nulls-aware-shorthands
branch
2 times, most recently
from
5399874 to
54f5c74
Compare
nowNick
force-pushed
the
fix/nulls-aware-shorthands
branch
from
54f5c74 to
c3321f4
Compare
bungle
approved these changes
Aug 28, 2024
jschmid1
approved these changes
Aug 28, 2024
samugi
approved these changes
Aug 28, 2024
StarlightIbuki
approved these changes
Aug 29, 2024
kikito
approved these changes
Aug 29, 2024
3 tasks
|
Successfully created backport PR for |
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13589-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13589-to-master-to-upstream
git checkout -b cherry-pick-13589-to-master-to-upstream
ancref=$(git merge-base 4d7934b85d23441f910aa3287c1fab4947e3055f c3321f4f580bd785d718bdf5949ae708d2081b04)
git cherry-pick -x $ancref..c3321f4f580bd785d718bdf5949ae708d2081b04 |
github-actions
bot
added
the
incomplete-cherry-pick
kikito
removed
the
incomplete-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When both new field and shorthand fields are used but the new field contains null value and the old field contains some other specific value this change allows for that specific value to overwrite the new null value. If a user wants to set explicit null they have to send request without the old value.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-5287